Re: Re: How to create options for modopt
By: martylake to Digital Man on Wed Dec 08 2021 09:28 pm

Re: Re: How to create options for modopt
By: martylake to Digital Man on Tue Dec 07 2021 11:40 pm

Did you try setting utf8_support = false in the modopts.ini file? It doesn't look like this logic would work to me. The "|| true" would make the UTF-8 support *always* enabled (when the terminal supports UTF-8).

No I had not tried to set utf8_support in the modopt.ini . After trying, the option is indeed ignored by " || true".
What I wanted to express is: "true unless the option exists and is set". See diff below, this time I manually tested that it works for all 3 cases: option section missing, option disabled and option enabled.

Also the option should probably sit in "chat_sec" section, not "fseditor". Reflected in bellow's diff.

diff --git a/exec/irc.js b/exec/irc.js
index 672dc73c0..44e21620c 100644
--- a/exec/irc.js
+++ b/exec/irc.js
@@ -35,8 +35,12 @@ js.on_exit("console.ctrlkey_passthru = " + console.ctrlkey_passthru);
console.ctrlkey_passthru=~(134217728);
var pmode = 0;

-var options = load('modopts.js', 'fseditor');
+var options = load('modopts.js', 'chat_sec');
-var utf8_support = ((options && options.utf8_support) || true) && console.term_supports(USER_UTF8); //default to true
+var utf8_support = true;
+if(options && options.utf8_support)
+{
+ utf8_support = console.term_supports(USER_UTF8);
+}
if(utf8_support)
{
pmode |= P_UTF8;

Did you ever get this patch into a final state? The ideal thing would be to submit a merge request at gitlab.synchro.net. I'd be happy to accept/merge it into our master branch if you're happy with it.
--
digital man (rob)

Rush quote #41:
Angels and demons dancing in my head, lunatics and monsters underneath my bed Norco, CA WX: 57.4øF, 71.0% humidity, 2 mph E wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: Re: How to create options for modopt
By: Digital Man to martylake on Thu Jan 06 2022 10:20 pm

Did you ever get this patch into a final state? The ideal thing would be to submit a merge request at gitlab.synchro.net. I'd be happy to accept/merge it into our master branch if you're happy with it.

I never heard back, so I went ahead and committed a change base mostly on your patch set. Hopefully that works as expected for everyone.
--
digital man (rob)

Synchronet "Real Fact" #57:
Synchronet introduced Telnet, FTP, SMTP and POP3 support w/v3.00a-Win32 in 2000 Norco, CA WX: 55.9øF, 91.0% humidity, 0 mph SE wind, 0.00 inches rain/24hrs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net