src/sbbs3 userdat.c 1.229 1.230
Update of /cvsroot/sbbs/src/sbbs3
In directory cvs:/tmp/cvs-serv27150

Modified Files:
userdat.c
Log Message:
Recognize the "quiet" directory setting (no download notifications) for
the JS User.downloaded_file() method (used by ecWeb's file download stuff). Thanks Coz.



---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/1e9d5c2cc05ee318ab629bce
Modified Files:
src/sbbs3/userdat.c
Log Message:
Treat every login failure with no password available as unique

When loginFailure() is called with NULL for the password argument, that indicates there was no password available (e.g. an aborted login attempt) - treat each of these as a unique (not duplicate) failed-login attempt. This'll trigger ban/filter thresholds sooner for clients that hammer servers and disconnect mid-login.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/sbbs/sbbs/-/commit/5168429f4fae5bfda1fa9976
Modified Files:
src/sbbs3/userdat.c
Log Message:
My first opportunity to use IS_ALPHANUMERIC ()instead of isalnum()

and I blew it. Here's to learning new tricks.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0f76860d6b42af92589f6fa2
Modified Files:
src/sbbs3/userdat.c
Log Message:
Include the [F] (forced chat) flag for help in debugging forced-chat.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3eaf57fe30820f5b0f232328
Modified Files:
src/sbbs3/userdat.c
Log Message:
C version of chk_ar() now supports the DOS keyword...

The "DOS" ARS keyword was always evaluating to false, on all platforms, for the C version of chk_ar(), which is used for populating JS *_area objects and for the User.compare_ars() implementation.

Unfortunately, the startup (sbbs.ini) "NO_DOS" option is not recognized here (yet), so it'll report true (e.g. for Win64 or Linux systems with DOSemu) even if/when the NO_DOS option is set.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0b3804ff58b0611e544fb932
Modified Files:
src/sbbs3/userdat.c
Log Message:
Don't compare array against NULL

Addresses CID 319116 and 319090

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/9c1594949415dda47210ad23
Modified Files:
src/sbbs3/userdat.c
Log Message:
Let's make that semfile just sound.mute

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/55d6d6b8c0c8e92522a45c42
Modified Files:
src/sbbs3/userdat.c
Log Message:
Get rid of an unnecessary strcat() call

CID 33567

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e6bc098025fb9ffb263f8ce4
Modified Files:
src/sbbs3/userdat.c
Log Message:
Ignore trailing non-alpha-numeric characters in matchusername()

A name ending in a symbol (e.g. "Erich B.") would cause problems with this matching logic.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/40eec7fa665daee9c365e43f
Modified Files:
src/sbbs3/userdat.c
Log Message:
Posts from QWKnet users don't count as "posts" for local stats

Might add some other statistic for these relayed posts at some point.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/14940b8a7f261cb137b69035
Modified Files:
src/sbbs3/userdat.c
Log Message:
Fix possible underflow conditions in gettimeleft()

If a non-'T' exempt user had already used more time today than their security level allows, their timeleft would be computed as a negative value due to integer underflow. Since the return value of this function is assigned to a ulong (timeleft), this becomes a large positive number. Cap the floor of the computed time left at 0.

Also fix the potential for underflow that could occur if the system clock changes while a user is online and 'now' becomes greater than 'starttime'.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8ad5e191568032ec2d91c79f
Modified Files:
src/sbbs3/userdat.c
Log Message:
matchuser() now always returns 0 when passed an empty 'name'

Also, don't match against deleted (blank) usernames in name.dat
(e.g. when 'name' value consists of a single ETX character).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/6c0e423a38920f64abfb7013
Modified Files:
src/sbbs3/userdat.c
Log Message:
Don't truncate a user's record if the default download protocol or gender are '\0'

A blank download protocol field in a user.dat, when parsed, sets the 'prot' field
of user_t to 0. When writing the record back to the user.dat, this would prematurely
truncate all other fields off the user record (since strings in C are NUL terminated
and we're using sprintf() to format the record and %c specifier for that field).

The fix is to write a ' ' character instead of '\0' if the user_t.prot is '\0'. As part of this fix, I'm writing a '?' if a user_t.sex is '\0' (not sure if this
is actually possible, but just as insurance). Those are the only 2 single-character
user properties/fields today.

Bug reported/debugged by Al of The Rusty Mailbox (1:153/757.2) - thank you!

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net