• src/sbbs3/js_msg_area.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, January 01, 2021 17:28:31
    https://gitlab.synchro.net/main/sbbs/-/commit/2d421cb3bc706591c9f76508
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Fix: can_* and is_* properties were not dynamic. Added "posts" property.

    The following properties would only reflect the status at the time the
    msg_area object was initialized:
    - can_access
    - can_read
    - can_post
    - is_operator
    - is_moderated

    ... so if changes were made the user while online, for example, these
    property values would *not* also change to reflect the current state.

    The grp[] and grp_list[] 'can_access' properties still have this flaw.

    Also: Add a new "posts" property to the sub[] and sub_list[] objects to
    report the current number of posted messages (quicker than opening a MsgBase instance).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, January 01, 2021 17:41:36
    https://gitlab.synchro.net/main/sbbs/-/commit/b6584f1e735f735feb3079fd
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Fix NULL-ptr dereferences when subscan is NULL

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, January 01, 2021 18:34:20
    https://gitlab.synchro.net/main/sbbs/-/commit/a30b854100676b2c72aadfdc
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    "posts" property doesn't rely on subscan pointer.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, January 04, 2021 12:56:50
    https://gitlab.synchro.net/main/sbbs/-/commit/9314c48c862d5767842cba08
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Fix sub[] property setter - private data pointer type wrong

    The private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, January 04, 2021 13:34:36
    https://gitlab.synchro.net/main/sbbs/-/commit/48709dcb456c6ef94d2ada39
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Fix: sub[] property getter needs to return TRUE always

    ... even when there's no private data.

    Should fix "TypeError: sub.code is undefined"

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Nightfox@VERT/DIGDIST to Rob Swindell on Monday, January 04, 2021 13:35:56
    Re: src/sbbs3/js_msg_area.c
    By: Rob Swindell to Git commit to main/sbbs/master on Mon Jan 04 2021 12:56 pm

    The private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.

    I've seen the posts on the crashes. I'm not entirely sure what the isue might be, but do you think there's anything I might need to change in my reader?

    Nightfox

    ---
    Synchronet Digital Distortion: digitaldistortionbbs.com
  • From Digital Man@VERT to Nightfox on Monday, January 04, 2021 14:00:12
    Re: src/sbbs3/js_msg_area.c
    By: Nightfox to Rob Swindell on Mon Jan 04 2021 01:35 pm

    Re: src/sbbs3/js_msg_area.c
    By: Rob Swindell to Git commit to main/sbbs/master on Mon Jan 04 2021 12:56 pm

    The private data pointer is no longer a subscan_t*. This likely explains the reported crashes when using DDMsgReader and the most recent changes (fixes) to the msg_area object.

    I've seen the posts on the crashes. I'm not entirely sure what the isue might be, but do you think there's anything I might need to change in my reader?

    No, it was just a side-effect of a different bug-fix I made on Jan-1. The side-effect bug should now be fixed too.
    --
    digital man

    Synchronet/BBS Terminology Definition #55:
    PCMS = Programmable Command and Menu Structure (introduced in SBBS v2)
    Norco, CA WX: 62.8F, 58.0% humidity, 10 mph ENE wind, 0.00 inches rain/24hrs

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, January 04, 2021 18:53:09
    https://gitlab.synchro.net/main/sbbs/-/commit/9e85be8fe69371e310899e2f
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Setter needs to return true even when the scan pointer is NULL

    (e.g. when run as a timed event) - this bug was introduced in the "Fix sub[] property setter" crash bug fix 2 commits ago.
    This fixes the "TypeError: sub.code is undefined" error.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, April 04, 2021 13:38:22
    https://gitlab.synchro.net/main/sbbs/-/commit/2faa619e13ae9d9164f87195
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    mod_ar is not a pointer, it's an array.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Friday, February 10, 2023 21:52:17
    https://gitlab.synchro.net/main/sbbs/-/commit/58a0af35627eadbbdb4e4159
    Modified Files:
    src/sbbs3/js_msg_area.c
    Log Message:
    Add 'fidonet_addr' property to msg_area.sub[]

    Fixes issue #398

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net