• exec/load/birthdays.js

    From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, August 26, 2020 20:01:32
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c0f433f77c992fec25105b83
    Modified Files:
    exec/load/birthdays.js
    Log Message:
    Remove unnecessary read of user #1

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wednesday, May 18, 2022 18:39:32
    https://gitlab.synchro.net/main/sbbs/-/commit/ddd4d10b26cfca1af5aebf50
    Modified Files:
    exec/load/birthdays.js
    Log Message:
    Fix loop limit (system.stats.total_users != system.lastuser)

    When looping to highest user number, use system.lastuser, not system.stats.total_users.

    This explains why not all userbases would be affected by the just-fixed
    issue in js_user.c. If the total_users happens to equal lastuser, then
    you would have hit the issue in js_user.c. If you had at least one
    deleted or inactive user account, then system.stats.total_users would
    be less than system.lastuser and your system would *not* have triggered
    that bug.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net