• src/sbbs3/useredit.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, September 03, 2020 18:45:51
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/276a4a5b2409ed199eb333a2
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Allow left/right/home/key keys to navigate users in online "UEDIT"
    - as requested (and insured) by Nelgin

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sunday, September 13, 2020 20:07:29
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/53e44f9b6c291691811fde16
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Don't prompt UTF-8 terminal users to ask if they support CP437.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 23, 2020 18:42:41
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/98d4f0839217108314a838d5
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Allow forward-to-netmail option to be toggled off by user

    Bug introduced in commit a2f5990b4db (Sept-11):
    By calling putuserrec() before modifying user->misc and then calling
    noyes(), we're giving an opportunity for the low-level node sync code to
    read the modified "useron" back from the database, thus losing the change
    we just made to user->misc. Instead, move the putuserrec() call to the end
    of the case statement. Another option would have been to turn off the NETMAIL flag before the first call to putuserrec().

    Bug reported by Nugax (BYTEXCHG)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, July 31, 2021 13:00:34
    https://gitlab.synchro.net/main/sbbs/-/commit/a53829d34393689015add034
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Stop beeping at the sysop when user-searches are successful.

    If anything, I suppose would be beep if a search fails, but really, I think beeps are kind of annoying these days. Not changing the currently selected/viewed user is likely all that's really needed to indicate a search failure.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, March 06, 2022 16:06:49
    https://gitlab.synchro.net/main/sbbs/-/commit/d8c36d9d898830fa0b8456f9
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Remove unnecessary current user (co-sysop) level/flag checks

    As Andre pointed out, these checks perform no function because a user with a level lower than the user being edited cannot enter the related command-key anyway.

    This was just effectively dead code that was held-over from ancient SBBS days, seemingly before I learned to effectively use the || operator:
    if(!(atoi(str)>useron.level && console&CON_R_INPUT))

    :-)

    Fixes issue #361

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, December 30, 2022 16:20:50
    https://gitlab.synchro.net/main/sbbs/-/commit/c7eb313c0a749c22975e5a37
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Don't assign to unused variable

    CID 433272

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, January 21, 2023 21:49:11
    https://gitlab.synchro.net/main/sbbs/-/commit/d83001e8cff767fcd80261d6
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Better handling of Quit/Ctrl-C at default protocol selection

    IF user hits 'Q' (or whatever the "Quit" key is), set the default protocol field in the user record to " " (instead of an empty string).
    If user hits abort (Ctrl-C), don't make any change to the default protocol.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Thursday, September 14, 2023 21:28:57
    https://gitlab.synchro.net/main/sbbs/-/commit/8d60770fa44d0ea8dd09d48b
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Change external editor yes/no prompt default to match current user setting

    Also, although not a bug (because we re-read/parse the user's record every
    menu cycle), don't decrement user.xedit before calling uselect()
    - just not a good practice to not modify variables unnecessarily.
    See the corresponding change to exec.cpp, which was a bug.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Saturday, September 23, 2023 20:29:02
    https://gitlab.synchro.net/main/sbbs/-/commit/d71cce5ffce2d856b8b0f783
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Clear line counter before starting the user settings/config menu.

    Fixes unnecessary [Hit a key] prompt.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, November 22, 2023 15:30:20
    https://gitlab.synchro.net/main/sbbs/-/commit/0bd7a0af71cf7e7b13edc6bc
    Modified Files:
    src/sbbs3/useredit.cpp
    Log Message:
    Fix CID 32913

    getkeys() could return -1 if user disconnects (and SS_ABORT not set), so this appears to be a valid bug.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net