• src/xpdev/xpbeep.c

    From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, March 17, 2021 23:41:53
    https://gitlab.synchro.net/main/sbbs/-/commit/123f60d7afd45bf788bedf42
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix ALSA output on Linux

    It seems that the "real" ALSA will actually silently fail if you
    try to clear errors when no errors have occured. The FreeBSD
    emulation of ALSA does not have this insane requirement, so this
    went unnoticed for the 1.1 release.

    I suspect that this actually fixes SF bug 24, because ALSA is
    preferred over pulseaudio.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 00:15:18
    https://gitlab.synchro.net/main/sbbs/-/commit/dc1d24b3b16cc0210c56cfd1
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Re-enable PulseAudio, ensure the handle is set to NULL on close.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 09:58:31
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9f3d6e3a62fa3e288cdaf4
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Do what was likely intended by 8b6b7b7c

    The previous attempt completely disabled pulse audio.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 14:24:32
    https://gitlab.synchro.net/main/sbbs/-/commit/e07b57962248e5cc907ca032
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    When trying to open pulse, play a millisecond of silence

    This allows the playback thread to open the device and errors to
    be checked. Otherwise, the first sound won't play.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 14:25:58
    https://gitlab.synchro.net/main/sbbs/-/commit/e07d1380e650ce7992444f1f
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix bug in last commit (extra parameter)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 14:27:14
    https://gitlab.synchro.net/main/sbbs/-/commit/0ef63571e50584c81e2e3da4
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Remove debug crap.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 18:37:54
    https://gitlab.synchro.net/main/sbbs/-/commit/606762311f25c816bdb153ee
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix the single-threaded build:

    error: `handle_mutex' undeclared

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Friday, March 19, 2021 11:05:12
    https://gitlab.synchro.net/main/sbbs/-/commit/d5e788518f41cbfddf9b3273
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix race condition when handle is opened by playing a sample.

    Caused a SyncTERM hang if it played a FG beep.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Wednesday, February 07, 2024 12:23:42
    https://gitlab.synchro.net/main/sbbs/-/commit/574712547b2d63bf5dcab0f9
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Another Windows warning about constiness.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, February 10, 2024 21:49:16
    https://gitlab.synchro.net/main/sbbs/-/commit/2e2ab2510aa35d61fda176c1
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Fix some warnings.

    We can't use const protection for the sample buffer because the Win32
    API takes non-const buffers. For standard implicit conversions,
    simply disable the warning where it occurs on purpose. It appears
    that MSVC builds use the equivilent of -Wconversion (which isn't even
    part of -Wall).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Saturday, February 10, 2024 22:10:30
    https://gitlab.synchro.net/main/sbbs/-/commit/1c47d84c7c55b6f6cffc0e06
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    _MSC_VER is the macro name you're looking for there :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Saturday, February 10, 2024 22:28:17
    https://gitlab.synchro.net/main/sbbs/-/commit/abf1cd9ee46327a9d17cba0b
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Actually remove the const the comment says I can't have.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, February 22, 2024 06:50:40
    https://gitlab.synchro.net/main/sbbs/-/commit/63cec349ee714376a2649e5f
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Remove need_copy variable when it won't be used.

    Fixes Coverity issue.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¨@VERT to Git commit to main/sbbs/master on Thursday, February 22, 2024 07:03:57
    https://gitlab.synchro.net/main/sbbs/-/commit/ea42fffa92392454971c1cfd
    Modified Files:
    src/xpdev/xpbeep.c
    Log Message:
    Keep pointers to dll_handle around to solence Coverity issues.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net