• src/sbbs3/getkey.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Friday, September 04, 2020 20:24:29
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/f4e3e9da454cb9237ab6b585
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Resolve gcc warning: unused variable ‘term’

    Also optimization of spinning cursor: don't call strlen() for each spin

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 09, 2020 02:22:08
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/2411b2d723821f347f24ca9d
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Spinning cursor over the hardware cursor - disabled.
    Define SPINNING_CURSOR_OVER_HARDWARE_CURSOR to enable this experimental feature. I'm not sure I like it better than the way the spinning cursor
    has been displayed for decades (to the left of the hardware cursor).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, November 05, 2020 00:02:18
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/688b566bd32ddb4bee07d60e
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix logged garbage observed in release rPi3 builds

    The "insert key into keybuf" log line could contain garbage. Apparently
    in a release build, the nested scope stack variable is actually invalid
    after the end of the scope. Weird.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wednesday, November 22, 2023 15:30:20
    https://gitlab.synchro.net/main/sbbs/-/commit/94fe4232d00189c225b4fd1e
    Modified Files:
    src/sbbs3/getkey.cpp
    Log Message:
    Fix CID 469138

    getkeys() is actually never (currently) called with a NULL arg, so this
    could not actually occur, but better to prepare for that eventuality.

    This looks like a case of not following the YAGNI principle.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net