https://gitlab.synchro.net/main/sbbs/-/commit/b417647b95c4fa921624034c
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Check batch-uploaded filenames for illegal characters/sequences/names

The BadFilename text.dat is now a format string (prints the bad filename).
Use the nice progress() display status while searching for duplicate filenames.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0c5c140eceeb8012a8083f6a
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Call smb_freefilemem() instead of smb_msgmem() for files

Not that it really matters, but perhaps it'll matter in the future. And the code reads better.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7dc1bc798e5a06e2278711ea
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix segfault after batch-upload when no "uploads" dir specified

When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir[] to determine if the time used for uploading the files should be "given back" to the user.

In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.

Reported by Zolt n G bor on Facebook

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/51e80cb165b7f4a1e096a172
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix potential divide by zero

CID 330961

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7e5ab9ab05d3a20fc6446e83
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Just use our local C macro MAX()

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d785ec9fc194d967e7bcda6d
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Add a sort (alphabetical) option when listing batch queues

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7696a52f02540c1b5347ae8f
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Sort the batch queues in the .ini files as well

This insures that the 'R'emove file option will work correctly if when displayed sorted.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/a0ce3cd799d2a79e4f0b5e0b
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Use the user's default download protocol for batch downloads

Oversight probably during the new filebase overhaul in v3.19. Reported by Nelgin.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e487e3cdb5ea842006d5dd6d
Modified Files:
src/sbbs3/bat_xfer.cpp
Log Message:
Fix warning about impossible condition.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net