When there's no "uploads" directory configured by the sysop, cfg.upload_dir will be set to INVALID_DIR, which cannot be used as an index into cfg.dir to determine if the time used for uploading the files should be "given back" to the user.
In v3.18, we used the first file in the upload queue, if there was one, else fell back to the "uploads" dir (which had to have been defined if there were no files in the queue). So this illegal array indexing was a regression in v3.19.
Reported by Zoltán Gábor on Facebook
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
From Rob Swindell@VERT to Git commit to main/sbbs/master on Wednesday, February 23, 2022 23:25:45