• exec/imapservice.js

    From rswindell@VERT to CVS commit on Monday, February 03, 2020 21:17:26
    exec imapservice.js 1.71 1.72
    Update of /cvsroot/sbbs/exec
    In directory cvs:/tmp/cvs-serv12689

    Modified Files:
    imapservice.js
    Log Message:
    All calls to MsgBase.get_msg_header() need the "expand fields" option
    disabled since the header may later be written back to disk. Should fix
    error reported by Ragnarok (DOCKSUD):
    imapservice.js line 1763: Error: Message header has 'expanded fields'



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Monday, February 03, 2020 21:19:36
    exec imapservice.js 1.72 1.73
    Update of /cvsroot/sbbs/exec
    In directory cvs:/tmp/cvs-serv13164

    Modified Files:
    imapservice.js
    Log Message:
    Fix apparent bug in set_seen_flag(): wasn't passing the message header to base.put_msg_header(). I just happened to notice this while making the last
    fix committed. I'm guessing this particular code path hasn't been tested (?)



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 11, 2020 23:35:43
    exec imapservice.js 1.74 1.75
    Update of /cvsroot/sbbs/exec
    In directory cvs:/tmp/cvs-serv8513

    Modified Files:
    imapservice.js
    Log Message:
    MSG_VERIFIED isn't a thing. Replace with MSG_VALIDATED.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tuesday, August 11, 2020 23:48:14
    exec imapservice.js 1.75 1.76
    Update of /cvsroot/sbbs/exec
    In directory cvs:/tmp/cvs-serv11198

    Modified Files:
    imapservice.js
    Log Message:
    Resolve error on line 2017: TypeError: args[0].search is not a function
    when using iOS (iPad) mail client.



    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Monday, October 12, 2020 14:14:13
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/7831a1c1de4379362bc931c4
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix what appears to be an extra close paren in the eval() statement here

    <nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS RECV: a UID SEARCH FROM "Michiel"
    <nelgin> Oct 12 16:05:41 bbs synchronet: srvc 0099 IMAPv4-TLS !JavaScript /sbbs/exec/imapservice.js line 1867: SyntaxError: missing ; before statement
    <nelgin> I got a different type of error

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Monday, October 12, 2020 15:22:43
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/601a9fd5c9019e796a1c4035
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix line 1172: ReferenceError: SCAN_CFG_NEW is not defined

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, February 21, 2021 12:28:04
    https://gitlab.synchro.net/main/sbbs/-/commit/1fc2657fb74666d597ca753d
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix exception when line is null

    imapservice.js line 736: TypeError: line is null

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, February 27, 2021 22:29:09
    https://gitlab.synchro.net/main/sbbs/-/commit/5cb71b903d507865bffd0217
    Modified Files:
    exec/imapservice.js
    Log Message:
    Resolve line 712: Error: can't convert parseInt(line) to an integer

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Tuesday, March 16, 2021 16:20:05
    https://gitlab.synchro.net/main/sbbs/-/commit/0bd86726916aa0cf4f3ffc13
    Modified Files:
    exec/imapservice.js
    Log Message:
    Don't overwrite the base global with the index base when reading config

    This falls squarely into the "How did that ever work?" category.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Tuesday, March 16, 2021 21:37:15
    https://gitlab.synchro.net/main/sbbs/-/commit/c967d666b2173c2d04e46a24
    Modified Files:
    exec/imapservice.js
    Log Message:
    Rename variable for consistency.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 13:39:15
    https://gitlab.synchro.net/main/sbbs/-/commit/93b91ee77ae194970b429c85
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix two isses with IMAP service...

    1) user.number immediately after login() remains zero, but changes
    "sometime" after. Avoid using user.number right after login()
    call to generate filename. All data/user/0000.imap files can
    be deleted after this change.
    2) Saving Seen data would modify the object storing it when binary
    seen values were used. Use JSON.parse(JSON.stringify() to make
    a copy before saving and restore it afterward. Should fix issue
    reported by nickshanks1 over IRC.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Friday, April 02, 2021 23:51:30
    https://gitlab.synchro.net/main/sbbs/-/commit/7b3303e7890a73cd173ae4a8
    Modified Files:
    exec/imapservice.js
    Log Message:
    Check for invalid line thing...

    Implicated in possible infinite loop/OOM problems.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Friday, April 02, 2021 23:54:50
    https://gitlab.synchro.net/main/sbbs/-/commit/9e22b06fc5dc99f582bb3b30
    Modified Files:
    exec/imapservice.js
    Log Message:
    Improve error message

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Friday, April 02, 2021 23:59:36
    https://gitlab.synchro.net/main/sbbs/-/commit/45f6979765f51dfd725a467c
    Modified Files:
    exec/imapservice.js
    Log Message:
    Ensure line isn't valid is it's not read in parse_string()

    Thus appears to have been the root cause of the infinite loop/memory
    issue. Basically, line was never replaced if it didn't match
    ^{[0-9]+}$ and didn't result in a number when passed to parseInt()
    This resulted in an infinite loop that kept pushing zero-length
    strings into an array.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Monday, April 05, 2021 01:33:56
    https://gitlab.synchro.net/main/sbbs/-/commit/b376fc4921c58c0e3f9f5a2c
    Modified Files:
    exec/imapservice.js
    Log Message:
    Guard against Seen being undefined when saving config.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Monday, April 05, 2021 01:43:10
    https://gitlab.synchro.net/main/sbbs/-/commit/dbed4f1a7cdd31e71f838d40
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix last commit... there are bits that aren't Seen that are saved

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Tuesday, April 06, 2021 23:23:23
    https://gitlab.synchro.net/main/sbbs/-/commit/7993ca0c16241ece57a2769e
    Modified Files:
    exec/imapservice.js
    Log Message:
    Some more fixes...

    Fix bseen calculation and saving
    Only save seen data after all repsonses have been sent
    Stop processing when the socket has been closed

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, April 09, 2022 11:51:59
    https://gitlab.synchro.net/main/sbbs/-/commit/0ed2c5120ac61523dbffd713
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix TypeError: args[1].toUpperCase is not a function

    Issue #389 reported by Keyop:
    srvc 0324 IMAPS <Keyop> !JavaScript /sbbs/exec/imapservice.js line 653: TypeError: args[1].toUpperCase is not a function

    I'm not sure how you reproduce this error or what type args[1] is
    (apparently, not a string), but this fix it regardless. Please let me
    know.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Saturday, April 09, 2022 12:15:07
    https://gitlab.synchro.net/main/sbbs/-/commit/a7468eaa3752118744bc4a0e
    Modified Files:
    exec/imapservice.js
    Log Message:
    Throw more interesting errors when a continuation line read fails

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Deuc@VERT to Git commit to main/sbbs/master on Thursday, September 29, 2022 15:38:56
    https://gitlab.synchro.net/main/sbbs/-/commit/698583017282f94fb813213e
    Modified Files:
    exec/imapservice.js
    Log Message:
    Handle invalid credentials in imapservice

    Fixes #401

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tuesday, September 12, 2023 15:43:21
    https://gitlab.synchro.net/main/sbbs/-/commit/bbe3042acf2029e2798012d1
    Modified Files:
    exec/imapservice.js
    Log Message:
    Wrap the entire search logic in a try/catch statement

    This should effectively turn script-terminating errors into just warnings and thus at least working-around issue #397: the exceptions will be logged as warnings intead of errors, but still logged.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Friday, September 15, 2023 15:28:09
    https://gitlab.synchro.net/main/sbbs/-/commit/c6515aa6b972bdcb6987e102
    Modified Files:
    exec/imapservice.js
    Log Message:
    Wrap the body of parse_command() in a try/catch to turn errors into warnings

    As requested by Keyop in #synchrob0yyz

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Saturday, September 16, 2023 12:06:05
    https://gitlab.synchro.net/main/sbbs/-/commit/0335c9796ce7bea2551f75c4
    Modified Files:
    exec/imapservice.js
    Log Message:
    Fix error when client supplies invalid Base64 string during auth

    IIRC, the error was undefined has no properties or split() is not a function, something like that.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net