• src/sbbs3/chat.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, September 17, 2020 17:49:48
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ac94b066213538a0ef8d91aa
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Don't send unsupported key-strokes (e.g. ESC) to the chat partner

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, September 17, 2020 20:42:28
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/0e76bac12f80dc5c680e751b
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    strcpy() -> SAFECOPY()

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thursday, September 17, 2020 21:02:43
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c9e4cb7916a170361c440222
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix an off-by-one line bug in the "local side" of the split-screen-chat.

    This bug would cause the split-screen separator to repeat when the local
    side scrolled (if the terminal was 24 rows, bug didn't happen when local
    screen was 25 rows).

    This bug appears to have "always" been there. The split-screen separator is
    80 columns, so that forced a line wrap on the subsequent CRLF and the local_y value was "off-by-one". Just use ansi_gotoxy() instead and put the cursor
    where you think it is.

    Also, support > 24 row terminals for longer chat history (bottom half only).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, January 05, 2021 10:59:16
    https://gitlab.synchro.net/main/sbbs/-/commit/06da1523e7671e8619b0bf07
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Remove forced upper/lower input of node-message target

    At the request of WitNik (BGGRSCYN)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, February 21, 2021 18:55:45
    https://gitlab.synchro.net/main/sbbs/-/commit/08f3f5c9783bf49ce308e6ec
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Address Coverity-reported issue

    Check return value from read().

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, November 30, 2021 18:48:56
    https://gitlab.synchro.net/main/sbbs/-/commit/39c82c50c2c700d83d964360
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add a debug line when wrapping split-screen chat lines.

    Is this the point when the lost chars problem happens?

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, October 20, 2022 20:43:32
    https://gitlab.synchro.net/main/sbbs/-/commit/9229bef09f652b69825a98d9
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add error and debug level log messages to private chat

    When reading and writing characters to chat files, log each with a debug-level log message. If a read or a write fails, log with an error-level log message.

    This will hopefully help root-cause and resolve issue #304.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, October 20, 2022 20:57:43
    https://gitlab.synchro.net/main/sbbs/-/commit/1f04cc14152bc4312d490061
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Don't log debug msgs when reading 0 (\x00) from chat.dab file, expected

    This just resulted in a lot of unhelpful noise in the log output

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, October 21, 2022 12:10:19
    https://gitlab.synchro.net/main/sbbs/-/commit/1cdc4d8d590b1fa1a3506bee
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix-up the recently-added debug/error log messages

    I didn't look closely enough at which write() call I was instrumenting.
    This is now more useful, though I think we already found the root-cause
    based on different log output ("Unexpected ansi_getxy response").

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Thursday, February 02, 2023 13:48:41
    https://gitlab.synchro.net/main/sbbs/-/commit/b56bf8edcf92494e56d410aa
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)

    Be sure to let them select a node even when no nodes are technically "in use". As requested by Nelgin in IRC (what, no gitlab issue?)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net