• src/sbbs3/postmsg.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 30, 2020 21:25:17
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/97bade44ebad5b431485e93c
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Notify local recipients of locally-posted messages addressed to them.

    While SBBSecho would notify local users of imported messages addressed to
    them (both EchoMail and NetMail) and QWK-imported messages recently gained
    the ability to notify local recipients of messages addressed to them, other methods of posting messages (e.g. just using the normal terminal server
    method, e.g. the 'P' command) or using any JavaScript (e.g. web) methods of posting messages lacked recipient notifications. So that's now fixed.
    And for JavaScript-saved local email messages too. I don't *think* this will result in any duplicate notifications of received messages, but let me know
    if you see excess/duplicate notifications.
    Anonymously posted messages are excluded.
    Messages posted to yourself are excluded (who does that?).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, September 30, 2020 21:26:58
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/f4ac7f3920abba7d3c717e3d
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Resolve a gcc warning about signedness.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Saturday, October 03, 2020 12:16:52
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c8193766c6b75abb18a2c257
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Fix savemsg() bug introduced in 97bade44eb (Sep-30), returning false failure

    'i' is the return value of savemg(), used to determine success or failure
    (and what kind of failure) - so we can't use that for the usernumber of
    the recipient.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wednesday, November 11, 2020 17:55:49
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/a852cced25cbf1285825942f
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Reduce unnecessary posted-to username searches. Auto-UTF8 in savemsg().

    When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

    savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, March 18, 2021 21:24:40
    https://gitlab.synchro.net/main/sbbs/-/commit/54c935707ff58e948fb0df2b
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Move the tags prompt to *before* the locking of the message base

    Thanks Mr. Executive Chicken esq. for the telephone call and bug report.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sunday, April 04, 2021 15:13:57
    https://gitlab.synchro.net/main/sbbs/-/commit/489267ade424d4f40cf8b752
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    mod_ar is no longer a pointer, it's an array

    CID 319077

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tuesday, April 13, 2021 20:20:22
    https://gitlab.synchro.net/main/sbbs/-/commit/908618c85f29a300acc7a500
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Debug the "thread_back field missing" error

    Some QWKnet vote messages are failing:
    evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line 1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote thread_back field missing

    Catch this problem a little higher up (in votemsg()) and log the message's reply-IDs to help determine what's the root-cause here. Don't bother calling smb_addvote() if thread_back is 0.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Monday, October 24, 2022 15:49:30
    https://gitlab.synchro.net/main/sbbs/-/commit/33a8b69cfbbd8194e3519608
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Strip control chars/ctrl-A sequences from msg subject in notify()

    We may want Ctrl-A sequences in the telegram subject, but not in the message subject

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net