• src/sbbs3/zmodem.c

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, November 27, 2020 01:48:05
    https://gitlab.synchro.net/main/sbbs/-/commit/df15131bdb18831c6646ddff
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    zmodem_recv_files() now returns upon first failed file.

    Previously, a ZRINIT frame would be sent even after a failed file download, and this could be misinterpreted by the sender as a successful file receipt
    acknowledgement. 'lrz' just completely aborts the receive "batch" under the same conditions, so we'll just do the same to prevent the sender (e.g. BBS) from mistakenly counting this as a successful transfer (download).

    A lot of log message updates: additions, removals, and use of the __FUNCTION__ macro.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, November 27, 2020 02:04:08
    https://gitlab.synchro.net/main/sbbs/-/commit/6ffdef9ff1449de30ea478ce
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Fix build error introduce in previous commit.

    __FUNCTION__ cannot be used a string literal in GCC.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, November 27, 2020 14:07:55
    https://gitlab.synchro.net/main/sbbs/-/commit/8a4698c5a581d8a42c462878
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Include file/progress byte-offset at the beginning of log messages

    Makes easier trace/debugging of issues (e.g. matching up with sending side logs).
    No functional change.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Friday, November 27, 2020 22:02:22
    https://gitlab.synchro.net/main/sbbs/-/commit/b8797f3e9335f0bb89883cdb
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    More log output messages/detail. No functional change.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, November 28, 2020 00:39:25
    https://gitlab.synchro.net/main/sbbs/-/commit/d1259998004d6e3f47be6066
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    zmodem_recv_file_data() will purge receive buffer before sending ZRPOS, but...

    only when the errored data subpacket was a ZCRCW (waiting for ZACK).
    To resolve a non-streaming failure to recover after CRC error issue.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, November 28, 2020 02:43:29
    https://gitlab.synchro.net/main/sbbs/-/commit/421db04420bcc48b5ca3f38f
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Insure receive buffer is purged before sending ZRPOS.

    Also, zmodem_send_raw() was saving the "last sent" char, even if it wasn't successfully sent.

    Eliminated the "errors" mode of zmodem_recv_header_raw() since was no longer used.
    Eliminated zmodem_recv_header_and_check() since it's no longer used.

    Some debug-log fix-ups (e.g. with progress/offset).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, November 28, 2020 05:07:12
    https://gitlab.synchro.net/main/sbbs/-/commit/074edbc12b9163e8a0e8e10b
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Better HEX frame corruption detection.

    More logging details (e.g. subpacket byte progress).
    Identify XON and XOFF by name (e.g. when purging receive buffer).
    Some variable naming and comment improvements.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, February 13, 2021 15:14:08
    https://gitlab.synchro.net/main/sbbs/-/commit/12ac1fc4c828739d5a76e66b
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Accept hex headers terminated with 0x8A

    Some ZMODEM implementations set the high bit (even parity?) when sending this '\n' terminator.
    As reported via IRC:
    <Keyop> sexyz: !zmodem_recv_hex_header HEX header not terminated with LF: 138 (8Ah)

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Saturday, February 13, 2021 16:40:27
    https://gitlab.synchro.net/main/sbbs/-/commit/0f7716c038d4a6f37947f888
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Strip/ignore high (parity) bit in ZPAD, ZDLE, and hex headers

    The previous committed fix/issue raised some additional concerns about this "parity" bit:

    Something I didn't notice before from the ZMODEM spec:
    "The hex header receiving routine ignores parity."

    And looking at lrzsz's zm.c, I see it goes even further and ignores the "parity" bit on the ZPAD and ZDLE bytes proceeding the frame encoding byte as well as in the frame encoding byte itself (so ZHEX, 'B' 0x22 and 0xC2 should be treated as equivalent).

    I find it strange that some ZMODEM implementations (e.g. chuck's zshhdr()) would send the terminating LF with the even-parity bit set, but not set the even-parity flag for any of the frame content bytes. And then, expect that the parity flag may be set on incoming hex headers. I suppose it makes sense for 7-E-1 connections, but then the transmitted terminating LF would have had its parity flag set automatically (would not need to be set manually in the code). Add to the mysteries of ZMODEM that will likely never be solved.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thursday, April 28, 2022 14:05:48
    https://gitlab.synchro.net/main/sbbs/-/commit/3bfa626d494d44afd5d6e32a
    Modified Files:
    src/sbbs3/zmodem.c
    Log Message:
    Fix erroneous error message

    Subpacket OVERFLOW means received subpacket byte offset is >= the max subpacket length.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net